Add more information to PeerConnectionAnalyzer logs #14442
+404
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Otherwise it was not possible to know if the logged stats belonged to the video or screen peer. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The raw RTC stats provide additional information that is sometimes needed to debug the connection quality warning, so they are now included in the logs. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
add-more-information-to-peerconnectionanalyzer-logs
branch
from
9202347 to
9e2ccae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #14095
Requires #14419 (as otherwise there would be conflicts once that one is merged)
The additional information in the logs should help to debug connection warnings and find out if they were legit or false positives that still need to be fixed.
Although it would not be strictly needed to backport this to 29 and 30 it might help to avoid conflicts with backports of future fixes.
TODO